chore: optimize recoverWith to avoid some materialization #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
recoverWthOpt
branch
from
01c96ac to
c6b3b19
Compare
pjfanning
reviewed
Feb 22, 2025
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/Ops.scala
Outdated
Show resolved
Hide resolved
He-Pin
force-pushed
the
recoverWthOpt
branch
from
c6b3b19 to
fb25f71
Compare
He-Pin
force-pushed
the
recoverWthOpt
branch
2 times, most recently
from
baea7be to
ea43a78
Compare
|
@pjfanning @Roiocam I think this one is ready. |
pjfanning
reviewed
Feb 28, 2025
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowRecoverWithSpec.scala
Outdated
Show resolved
Hide resolved
I think we can do a sortimports globally.. |
He-Pin
force-pushed
the
recoverWthOpt
branch
from
ea43a78 to
240515f
Compare
pjfanning
approved these changes
Feb 28, 2025
pjfanning
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
refs： #1663
Result:
Avoid some materialization.